Migrate backends/vulkan to the new namespace #5876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move the vulkan backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Differential Revision: D63903939
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5876
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9ece0ce with merge base c2969f1 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/periodic
module: vulkan
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63903939 |
junpi3
approved these changes
Oct 4, 2024
Contributor
|
This pull request has been merged in b9e9479. |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Summary: Pull Request resolved: #5876 Move the vulkan backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Reviewed By: jorgep31415 Differential Revision: D63903939 fbshipit-source-id: 42ff0ba2b560eb3e2bee02c014e39f44d7b0ec94 (cherry picked from commit b9e9479)
Collaborator
Cherry picking #5876The cherry pick PR is at #5897 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 4, 2024
Migrate backends/vulkan to the new namespace (#5876) Summary: Pull Request resolved: #5876 Move the vulkan backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Reviewed By: jorgep31415 Differential Revision: D63903939 fbshipit-source-id: 42ff0ba2b560eb3e2bee02c014e39f44d7b0ec94 (cherry picked from commit b9e9479) Co-authored-by: Dave Bort <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move the vulkan backend out of the
torch::namespace, and update to avoid using thetorch::orexec_aten::namespaces.Differential Revision: D63903939